Fix #14074 FP constParameterReference reported for std::array object when non-const pointer to internal data is returned #7890
Conversation
lib/valueflow.cpp
Outdated
| const Library::Container* library = getLibraryContainer(tok->tokAt(-2)->astOperand1()); | ||
| const Library::Container::Yield y = library->getYield(tok->strAt(-1)); | ||
| if (y == Library::Container::Yield::AT_INDEX || y == Library::Container::Yield::ITEM) { | ||
| if (contains({Library::Container::Yield::AT_INDEX, Library::Container::Yield::ITEM, Library::Container::Yield::BUFFER, Library::Container::Yield::BUFFER_NT}, y)) { |
There was a problem hiding this comment.
This is not correct, The buffer returns a pointer not a reference so it should not be used here.
There was a problem hiding this comment.
The function is called getLifetimeTokens() though?
There was a problem hiding this comment.
Its get the lifetime of a reference. Thats why the it only follows the function that return references(see here). Its similar to followReferences, but different as it will get the parent lifetime of a reference as well.
Originally, it was called getLifetimeVariable(and there is still an overload for this), but was renamed to getLifetimeTokens so it can handle expressions and multiple lifetimes.
The lifetime of pointers are set in valueflow in the token. For pointer to containers data() method, we set the lifetime here:
Line 3237 in 5f301d3
There was a problem hiding this comment.
There is no mention of pointers or references anywhere regarding those functions. But apparently the issue was in checkConstVariable().
There was a problem hiding this comment.
Sorry, that is my fault entirely since I wrote and named this function originally.
|
4 participants
No description provided.